java - Multiple problems in this code - Type: Missmatch -


so have written java code supposed tell user color if combining 2 other (from list) random selected colors. mind new java (have programmed in python before).

code:

    package listofwords;       public class testlistwords {   public static void main (string[] args) {        string [] colors = {"red","green","gray","black","blue","yellow"};        int colorslength = colors.length;        int rand1 = (int) (math.random() * colorslength);       int rand2 = (int) (math.random() * colorslength);        while(rand1==rand2){           int rand2 = (int) (math.random() * colorslength);       }        string phrase1 = colors[rand1];       string phrase2 = colors[rand2];               while(phrase1 = "green"){         if (phrase2 = "red") {           system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }        if (phrase2 = "gray") {           system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color dark green");         }        if (phrase2 = "black") {           system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }         if (phrase2 = "blue") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }          if (phrase2 = "yellow") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }         }     while(phrase1 = "red"){          if (phrase2 = "green") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }         if (phrase2 = "gray") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color dark red");         }         if (phrase2 = "black") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }         if (phrase2 = "blue") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }         if (phrase2 = "yellow") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }      }      while(phrase1 = "gray"){          if (phrase2 = "red") {         system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color dark red");         }         if (phrase2 = "green") {         system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color dark green");         }         if (phrase2 = "black") {         system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }         if (phrase2 = "blue") {         system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give dark blue");         }         if (phrase2 = "yellow") {         system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color green");         }      }      while(phrase1 = "black"){          if (phrase2 = "red") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }         if (phrase2 = "green") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }         if (phrase2 = "gray") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }         if (phrase2 = "blue") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give black");         }         if (phrase2 = "yellow") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }      }      while(phrase1 = "yellow"){          if (phrase2 = "red") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }         if (phrase2 = "green") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color blue");         }         if (phrase2 = "gray") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color green");         }         if (phrase2 = "blue") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give green");         }         if (phrase2 = "black") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }      }      while(phrase1 = "blue"){          if (phrase2 = "red") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }         if (phrase2 = "green") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color brown");         }         if (phrase2 = "gray") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give dark blue");         }         if (phrase2 = "yellow") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give green");         }         if (phrase2 = "black") {             system.out.print("combining" + " " + phrase1 + " " + "with" + " " + phrase2 + " " + "will give color black");         }     } }

}

so im getting error message saying:

    exception in thread "main" java.lang.error: unresolved compilation problems:      duplicate local variable rand2     type mismatch: cannot convert string boolean.

and im not sure how fix - please.

alright. there number of problems have written here. try address of them.

first off, bas pointed out, in general, if want compare 2 values see if equal, use ==, not =. example:

if ( x == y ) {   //do stuff }

second, bas pointed out, in java can't use == compare strings. need is:

if ( string1.equals(string2) ) {   //do stuff }

third. "while". 1 going cause lots of issues you. while means keep doing code follows, until test false. so, when this:

while ( mystring.equals( "bananas" ) ) {   system.out.println ( "lots of bananas." ); }

if string "bananas", you'll this:

lots of bananas. lots of bananas. lots of bananas. lots of bananas. lots of bananas. lots of bananas. lots of bananas. lots of bananas. ....

forever. want use if. actually, there convenient piece of logic here well. instead of bunch of if's, can modify statement use else ifs, since of these options mutually exclusive:

if ( string1.equals("yellow")) {   if ( string2.equals("green")) {     system.out.println("stuff");   }   else if ( string2.equals("blue")) {     system.out.println("more stuff");   } } else if ( string1.equals("green")) {   if ( string2.equals("blue")) {     system.out.println("lalala");   }   else if ( string2.equals("yellow")) {     system.out.println("more stuff");   } }

there better ways of writing program involve lot less code duplication , simpler logic, avoid overloading you, sufficient now.


Comments

Post a Comment

Popular posts from this blog

curl - PHP fsockopen help required -

i trying work on cloudflare api , have found in documentation. unfortunately have no idea how can use in fsockopen or through curl. here example of post request. need know how can make request below data post using curl or fsockopen curl https://www.cloudflare.com/api_json.html -d 'a=cache_lvl' \ -d 'tkn=8afbe6dea02407989af4dd4c97bb6e25' \ -d 'email=sample@example.com' \ -d 'z=example.com' \ -d 'v=agg' here link cloudflare https://www.cloudflare.com/docs/client-api.html#s4.2 try one: $ch = curl_init("https://www.cloudflare.com/api_json.html"); curl_setopt($ch, curlopt_returntransfer,1); curl_setopt($ch, curlopt_followlocation, 1); curl_setopt($ch, curlopt_ssl_verifypeer,false); // handling of -d curl parameter here. $param = array( 'a' => 'cache_lvl', 'tkn' => '8afbe6dea02407989af4dd4c97bb6e25', 'email' => 'sample@example.com', 'z' =...
Read more

HTTP/1.0 407 Proxy Authentication Required PHP -

i working in restricted network/limited access internet. since have use proxy make web service call. here php code calling web service , response . $client = new soapclient("http: //www.xyz.com/abc/wsdls/login.wsdl", array("trace" => 1, "exceptions" => 1, 'proxy_host' => $proxy_host, 'proxy_port' => $proxy_port, 'proxy_login' => $proxy_login, 'proxy_password' => $proxy_password)); response is fatal error: uncaught soapfault exception: [wsdl] soap-error: parsing wsdl: couldn't load ' http://www.xyz.com/abc/wsdls/login.wsdl ' : failed load external entity if copy url error message , paste in browser(with same proxy settings) works. 2nd scenario is, if pass values instead of variables giving me diffarant response $client = new soapclient("http: //www.xyz.com/abc/wsdls/login.wsdl", array("trace" => 1, "exceptions" => 1, 'proxy_host' ...
Read more

c# - Resource not found error -

i have problem accessing method on homecontroller. show code of method : [httpget] public actionresult decriptidentifiantetredirige(string login_crypter, string mdp_crypter) { string loginacrypter = _globalmanager.protegemotdepasse(login_crypter); string mdpacrypter = _globalmanager.protegemotdepasse(mdp_crypter); user userapp = new models.user(login_crypter, mdp_crypter); if (userapp.authentificationvalidee(userapp.userlogin, userapp.password)) { session["name"] = userapp.userlogin; return redirecttoaction("accueil", "home"); } else { return redirecttoaction("validerauthentification", "home"); } } then in routeconfig.cs wrote route : routes.maproute( name: "authentificationapresdecryptage", url: "{controller}/{action}/{login_crypter}/{mdp_crypter}", defaults: new...
Read more