Java- for loop using << operator -


i'm stuying code , don't understand line does: [(y << 3) + x]

    (int y = 0; y <= 7; ++y) {             (int x = 0; x <= 7; ++x) {                 final string piececode = piececodes[(y << 3) + x];                 if (piececode.length() != 2) throw new illegalargumentexception();                 if (!piececode.equals("--")) {                     pieces[((7 - y) << 3) + x] = checkerspiece.valueof(piececode.charat(0), piececode.charat(1));                    }             }         }

(y << 3) means bit shifting 3 times left. it's same multiplying 2^3 = 8. so, whole expression (y << 3) + x becomes y * 8 + x.

it should written in form y * 8 + x, because it's more readable , there no performance gain. premature optimization root of evil. it's better left such micro optimizations compiler (or jvm).

moreover, board size stored in constant, have in 1 place:

final int size = 8; // ... (int y = 0; y < size; y++) {     (int x = 0; x < size; x++) {         final string piececode = piececodes[y * size + x];

y * 8 + x iterating on (logically) 2d table 8 rows , columns, stored 1d, 64 cells.

as final remark, point out, in given code piececodes array of strings... in fact, it's array of piece codes. not some strings. now, "--" works magic state , nobody except programmer knows, means. if (piececode.length() != 2) looks bad. so, there should object piececode , array declared piececode[] piececodes. in piececode can implement proper equals() method. if piececode state, can enum. example empty, white_pawn, white_queen, black_pawn, black_queen. comparing strings not fast comparing enums. have watch out write equals(), instead of ==.


Comments

Post a Comment

Popular posts from this blog

curl - PHP fsockopen help required -

i trying work on cloudflare api , have found in documentation. unfortunately have no idea how can use in fsockopen or through curl. here example of post request. need know how can make request below data post using curl or fsockopen curl https://www.cloudflare.com/api_json.html -d 'a=cache_lvl' \ -d 'tkn=8afbe6dea02407989af4dd4c97bb6e25' \ -d 'email=sample@example.com' \ -d 'z=example.com' \ -d 'v=agg' here link cloudflare https://www.cloudflare.com/docs/client-api.html#s4.2 try one: $ch = curl_init("https://www.cloudflare.com/api_json.html"); curl_setopt($ch, curlopt_returntransfer,1); curl_setopt($ch, curlopt_followlocation, 1); curl_setopt($ch, curlopt_ssl_verifypeer,false); // handling of -d curl parameter here. $param = array( 'a' => 'cache_lvl', 'tkn' => '8afbe6dea02407989af4dd4c97bb6e25', 'email' => 'sample@example.com', 'z' =...
Read more

HTTP/1.0 407 Proxy Authentication Required PHP -

i working in restricted network/limited access internet. since have use proxy make web service call. here php code calling web service , response . $client = new soapclient("http: //www.xyz.com/abc/wsdls/login.wsdl", array("trace" => 1, "exceptions" => 1, 'proxy_host' => $proxy_host, 'proxy_port' => $proxy_port, 'proxy_login' => $proxy_login, 'proxy_password' => $proxy_password)); response is fatal error: uncaught soapfault exception: [wsdl] soap-error: parsing wsdl: couldn't load ' http://www.xyz.com/abc/wsdls/login.wsdl ' : failed load external entity if copy url error message , paste in browser(with same proxy settings) works. 2nd scenario is, if pass values instead of variables giving me diffarant response $client = new soapclient("http: //www.xyz.com/abc/wsdls/login.wsdl", array("trace" => 1, "exceptions" => 1, 'proxy_host' ...
Read more

c# - Resource not found error -

i have problem accessing method on homecontroller. show code of method : [httpget] public actionresult decriptidentifiantetredirige(string login_crypter, string mdp_crypter) { string loginacrypter = _globalmanager.protegemotdepasse(login_crypter); string mdpacrypter = _globalmanager.protegemotdepasse(mdp_crypter); user userapp = new models.user(login_crypter, mdp_crypter); if (userapp.authentificationvalidee(userapp.userlogin, userapp.password)) { session["name"] = userapp.userlogin; return redirecttoaction("accueil", "home"); } else { return redirecttoaction("validerauthentification", "home"); } } then in routeconfig.cs wrote route : routes.maproute( name: "authentificationapresdecryptage", url: "{controller}/{action}/{login_crypter}/{mdp_crypter}", defaults: new...
Read more